Updated ee_check_init() to compare earthengine-api version using #372
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numeric_version()
Collaborator
|
@csaybar I had the same problem, and I agree with this fix. Is there any chance you could accept it? Thanks! |
Collaborator
|
@NONONOexe Thank you for this contribution 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ee_check_init(), we verify that the earthengine-api version is compatible with rgee, specifically ensuring it's not newer than version 0.1.317. However, the latest version of earthengine-api (1.2.0) is incorrectly flagged as outdated due to the current comparison method.To address this issue, I updated the comparison approach to use
numeric_version(). This fix prevents unnecessary warnings from being triggered, such as when callingee_clean_user_credentials()with the latest earthengine-api version.