Skip to content

Conversation

@edzer
Copy link
Member

@edzer edzer commented Apr 11, 2023

See e.g. https://lin-ear-th-inking.blogspot.com/2020/05/jts-overlay-next-generation.html

I think this can only be considered progress, so suggest to merge with main.

Copy link
Member

@rsbivand rsbivand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, does make sense; I didn't spot the *Prec versions when updating rgeos for which this is now too late with only six months to archiving.

@edzer
Copy link
Member Author

edzer commented Apr 11, 2023

@paleolimbot I see from the geos sources that ...Prec_r() functions were introduced in 3.9.1-1, so that needs updating of the #ifdefs

@paleolimbot
Copy link
Contributor

I think it was probably introduced in GEOS 3.9 (which to my reading means that your ifdefs in this PR are OK)...I think that libgeos (in the R package sense) version 3.9.0 didn't exist which is why the version dependency is 3.9.1.

@paleolimbot
Copy link
Contributor

Agreed that it's progress! There is an analog in s2 as well (you can do an overlay with explicit precision there using the various snap options).

@edzer
Copy link
Member Author

edzer commented Apr 11, 2023

There is an analog in s2 as well (you can do an overlay with explicit precision there using the various snap options).

Now that you mention this - worth a post in the docs, or on r-spatial.org! Thanks,

@edzer edzer merged commit ce61d7f into main Apr 11, 2023
@edzer edzer deleted the geosng branch April 11, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants