Skip to content

Avoid 1: for possibly-empty input #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Avoid 1: for possibly-empty input #2189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/break_antimeridian.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ st_within_pm180 <- function(x, tol=0.0001) {
xcrs = st_crs(x)
xnames = names(x)
xnames = xnames[grep(attr(x, "sf_column"), xnames, invert=TRUE)]
x$st_within_pm180_ID = as.character(1:nrow(x))
x$st_within_pm180_ID = as.character(seq_len(nrow(x)))
s2_status = sf_use_s2()
sf_use_s2(FALSE) # avoid s2 because we need a planar bounding box
bb0 = st_bbox(x)
Expand Down
4 changes: 2 additions & 2 deletions R/sample.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ st_sample.sfc = function(x, size, ..., type = "random", exact = TRUE, warn_if_no
ret = if (progress) {
if (!requireNamespace("pbapply", quietly = TRUE))
stop("package pbapply required, please install it first")
pbapply::pblapply(1:length(x), function(i) st_sample(x[i], size[i], type = type, exact = exact, ...))
pbapply::pblapply(seq_along(x), function(i) st_sample(x[i], size[i], type = type, exact = exact, ...))
} else
lapply(1:length(x), function(i) st_sample(x[i], size[i], type = type, exact = exact, ...))
lapply(seq_along(x), function(i) st_sample(x[i], size[i], type = type, exact = exact, ...))
st_set_crs(do.call(c, ret), st_crs(x))
} else {
res = switch(max(st_dimension(x)) + 1,
Expand Down
2 changes: 1 addition & 1 deletion R/sp.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ st_as_sfc.SpatialPolygons = function(x, ..., precision = 0.0, forceMulti = FALSE
cp0 <- st_contains(raw0[!holes], raw0[holes])
areas <- sapply(slot(pl, "Polygons"), slot, "area")
hole_assigned <- rep(FALSE, sum(holes))
names(cp0) <- 1:length(cp0)
names(cp0) <- seq_along(cp0)
cp1 <- cp0[order(areas[!holes])]
for (i in seq_along(cp1)) {
cp1i <- cp1[[i]]
Expand Down