Skip to content

Dedupe init calls for non-super-respecting chains #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r-spiewak merged 2 commits into from
Jun 18, 2025
Merged

Dedupe init calls for non-super-respecting chains #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9141fc0
Dedupe init calls for non-super-respecting chains
r-spiewak Jun 18, 2025
cc5c710
Add comment on called set line
r-spiewak Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions src/python_template/utils/split_args_for_inits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def call_init_chain_respecting_super( # pylint: disable=too-many-locals,too-com
"""Call init methods of super-respecting classes via `super()` chain, and manually call
those that don't use `super()`.
"""
called = set()
# called = set()

# Step 1: Identify super-respecting classes:
# (crude guess: look at if "super" is in source)
Expand All @@ -379,15 +379,23 @@ def call_init_chain_respecting_super( # pylint: disable=too-many-locals,too-com
# except Exception:
# pass

# Step 2: Call init for non-super-respecting classes:
for base in cls.__mro__:
if base in (object, stop_at, skip_class) or base in called:
continue
if base not in super_respecting and base in split:
args = split[base].get("args", [])
kwargs = split[base].get("kwargs", {})
base.__init__(self, *args, **kwargs) # type: ignore[misc] # pylint: disable=unnecessary-dunder-call
called.add(base)
# Maybe skip this next step, since the classes will be called again
# as part of the super-respecting chains (as individual single-link
# chains)?
# # Step 2: Call init for non-super-respecting classes:
# for base in cls.__mro__:
# if base in (object, stop_at, skip_class) or base in called:
# continue
# if base not in super_respecting and base in split:
# args = split[base].get("args", [])
# kwargs = split[base].get("kwargs", {})
# if DEBUG_PRINTS:
# print(
# "[call_init_chain_respecting_super] Calling init of "
# f"non-super-respecting class {base.__name__}"
# )
# base.__init__(self, *args, **kwargs) # type: ignore[misc] # pylint: disable=unnecessary-dunder-call
# called.add(base)

# Step 3: Collect args and kwargs for super-respecting chain:
# first_bases = []
Expand Down Expand Up @@ -421,6 +429,11 @@ def call_init_chain_respecting_super( # pylint: disable=too-many-locals,too-com
for base in first_bases:
if base in (skip_class,):
continue
if DEBUG_PRINTS:
print(
"[call_init_chain_respecting_super] Calling init of "
f"super-respecting class {base.__name__}"
)
# super(base, self).__init__(*super_args[base], **super_kwargs[base])
base.__init__( # type: ignore[misc] # pylint: disable=unnecessary-dunder-call
self, *super_args[base], **super_kwargs[base]
Expand Down