Skip to content
This repository was archived by the owner on Oct 26, 2023. It is now read-only.

Conversation

@jonkeane
Copy link
Contributor

No description provided.

@jeroen jeroen merged commit 88b53d1 into r-windows:master Apr 26, 2021
@jeroen
Copy link
Contributor

jeroen commented Apr 26, 2021

OK I deployed this, but note that now you need to fix your R package, because you built w/ libre2, but currently in your R package you only link to with -lre2 for rtools40, but not for the backport:

https://github.com/apache/arrow/blob/master/r/configure.win#L59

So you need to change that to link to -lre2 unconditionally.

Before you submit to cran make sure to test on winbuilder, in particular the R-oldrelease flavour, which uses this backport.

@jeroen
Copy link
Contributor

jeroen commented Apr 26, 2021

Actually this doesn't seem to work with rtools35: https://win-builder.r-project.org/P5wwUznLPIRx/
I'll revert this for the backport.

jeroen added a commit that referenced this pull request Apr 26, 2021
@jeroen
Copy link
Contributor

jeroen commented Apr 27, 2021

OK I have switched the backport to -DARROW_WITH_RE2=OFF and now it should probably work, as was intended in your configure script in the first place.

@jonkeane
Copy link
Contributor Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants