Merged
Conversation
Sameesunkaria
force-pushed
the
support-swift-4.2
branch
from
b025e82 to
c61f22d
Compare
ra1028
requested changes
Sep 17, 2018
Owner
ra1028
left a comment
ra1028
left a comment
There was a problem hiding this comment.
Thanks @Sameesunkaria
Please check some comments.
| typealias RowAnimation = UITableView.RowAnimation | ||
| #else | ||
| typealias RowAnimation = UITableViewRowAnimation | ||
| #endif |
Owner
There was a problem hiding this comment.
I think this is the way to go, but is typealias RowAnimation = UITableView.RowAnimation needed in the Swift 4.2 or over?
Contributor
Author
There was a problem hiding this comment.
Nope. Added just to create symmetry.
| import UIKit | ||
|
|
||
| public extension UITableView { | ||
|
|
Owner
There was a problem hiding this comment.
[Nit] Please remove this empty line.
ra1028
reviewed
Sep 17, 2018
|
|
||
| public extension UITableView { | ||
| #if swift(>=4.2) | ||
| // Do nothing. UITableView has a RowAnimation enum |
Owner
There was a problem hiding this comment.
I think this comment is not needed.
#if swift(>=4.2)
#else
typealias RowAnimation = UITableViewRowAnimation
#endifAfter fixed, please squash your commits into one commit. (git rebase -i)
Sameesunkaria
force-pushed
the
support-swift-4.2
branch
from
56c2eff to
561aae4
Compare
Owner
|
@Sameesunkaria |
This was referenced Sep 17, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that swift 4.2 has been finalized and will be officially released shortly, I believe it is imperative that DifferenceKit supports it. The UIKit extensions were the only place where a change was needed.
NOTE: The code will still compile with swift 4.1, as language versions checks are being used to selectively compile the code.
The example project has not been updated to support swift 4.2, and should only be done when Xcode 10 is officially released.