Fix handling of file offsets with mixed sector lengths#9
Merged
aperezbios merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
Even though data tracks can be stored with 2048 bytes per sector, the offsets of audio tracks following it are calculated based on 2352 byte sectors. This results in padding in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though data tracks can be stored with 2048 bytes per sector, the offsets of audio tracks following it are calculated based on 2352 byte sectors. This results in padding in the file.
I found this a bit surprising, but the behavior of cdrdao matches.
@morio This fixes the "lacrazyc.zip" test case for me.