Skip to content

Conversation

@ShuaiShao93
Copy link
Contributor

This closes #2006

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to this change.

Please note that since the 28th of July 2025, all external contributors to RabbitMQ will have to sign a CLA again.

You have detailed instructions in [1][2].

Note companies that contribute to RabbitMQ only need to sign the CLA once, there is no need to make every
contributing employee to do so separately.

https://github.com/rabbitmq/cla
https://github.com/rabbitmq/rabbitmq-server/blob/main/CONTRIBUTING.md

@ShuaiShao93
Copy link
Contributor Author

No objections to this change.

Please note that since the 28th of July 2025, all external contributors to RabbitMQ will have to sign a CLA again.

You have detailed instructions in [1][2].

Note companies that contribute to RabbitMQ only need to sign the CLA once, there is no need to make every contributing employee to do so separately.

https://github.com/rabbitmq/cla https://github.com/rabbitmq/rabbitmq-server/blob/main/CONTRIBUTING.md

I have just signed the CLA. Can I merge this now?

@Zerpet Zerpet merged commit f9230da into rabbitmq:main Nov 19, 2025
47 of 48 checks passed
@Zerpet Zerpet added this to the 2.18.0 milestone Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set namespace in RoleBinding.subjects

2 participants