Use new rabbitmq-upgrade commands in preStop hook #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
requested changes
Sep 7, 2020
- as suggested by issue #255
ChunyiLyu
force-pushed
the
update-commands
branch
from
a411ab2 to
65bd760
Compare
ansd
approved these changes
Sep 8, 2020
MirahImage
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #255
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Use
rabbitmq-upgradecommands to check synchronization and quorum status, instead ofrabbitmq-queuescommands.Timeout is set to the same value as the default for grace period timeout.
Local Testing
Have run unit, integration, and system tests.