Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run unit, integration, helm chart, and system tests tests.
Closes to #270
System tests run against a kind cluster on a GitHub hosted Ubuntu VM.
Why not running the system tests against GKE?
This would require to add a GitHub secret with the GCP key file for authentication:
gcloud auth activate-service-account [ACCOUNT] --key-file=KEY_FILE.This comes with two drawbacks:
see https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets
When (accidentally) printing that JSON, the private key doesn't get redacted and would be accessible in the logs by every GitHub user:
The solution in google-github-actions/setup-gcloud#134 to base64 encode the secret isn't convincing.