Include k8s 1.20 in PR system tests #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirahImage
reviewed
Dec 9, 2020
coro
approved these changes
Dec 9, 2020
Contributor
coro
left a comment
coro
left a comment
There was a problem hiding this comment.
All good to me, just one question
.github/workflows/pr.yml
Outdated
| export PATH=$PATH:$GOPATH/bin | ||
| make install-tools | ||
| kind create cluster --image kindest/node:v1.19.1 | ||
| kind create cluster --image kindest/node:v1.19.4 |
Contributor
There was a problem hiding this comment.
1.20 is GA, right? So I feel we should probably be testing on 1.20 by default wherever we have a default (like here)
Contributor
Author
There was a problem hiding this comment.
Good point and updated!
- and bump k8s version 1.19.1 to 1.19.4 in system tests
MirahImage
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Additional Context
Not removing 1.17 from system tests matrixes just yet since many people are still using older version of k8s and it's not adding any feedback times to our PR workflow since it's parallel anyways