Mount tls secrets using projected volume not subpath #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- secrets and configmaps mounted with subpath do not not get updated in pods when changed, as reported in issue: kubernetes/kubernetes#50345 - RabbitMQ itself supports TLS credential rotation without restart. By mounting tls secrets without using subpath, rabbitmq pods will pick up cert changes and support tls rotation without server restart. - certificate rotation tested in system tests
ChunyiLyu
force-pushed
the
tls-rotation
branch
from
0ec4ad2 to
8427c41
Compare
- we should use Expect and Eventually with offset to make sure that the stack trace points to the failing line in system tests instead of the helper function
MirahImage
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #506
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
issue: ConfigMaps and Secrets mounted with subPath do not update when changed kubernetes/kubernetes#50345
Additional Context
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: