Prometheus fix standard port in TLS deploy #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gsantomaggio
changed the title
ansd
approved these changes
Jan 4, 2021
Member
ansd
left a comment
ansd
left a comment
There was a problem hiding this comment.
I just reviewed #533.
This fixes issue 1 described in #533 (review).
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the Prometheus standard port with the TLS deploy
I introduced this problem with this PR #533 found by @mkuratczyk
To recap the behaviour:
standard deploy:
tls deploy
disableNonTLSListeners=falsetls deploy
disableNonTLSListeners = true