Add support for Stream over TLS #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically configure TLS for the Stream plugin when TLS is enabled.
ChunyiLyu
approved these changes
May 26, 2021
Contributor
ChunyiLyu
left a comment
ChunyiLyu
left a comment
There was a problem hiding this comment.
Looks good although I have not manually tested it.
ansd
requested changes
May 26, 2021
ansd
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically configure TLS for the Stream plugin when TLS is enabled.
To test, I'd recommend
openssl s_client -connect INSTANCE-nodes.default.svc.cluster.local:5551.Integration tests will come later as the client's TLS support is still being worked on.