Test that nodes cluster correctly #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By querying the /nodes endpoint of the management API, we test that nodes cluster correctly. This test fails if we hit the issue described in #662.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing expectation that nodes cluster correctly.
The expectation should fail when we hit issue #662.
Additional context:
This test also serves as an integration test for the
rabbitmq_peer_discovery_k8splugin.Instead of having an extra integration test suite for
rabbitmq_peer_discovery_k8splugin in rabbitmq-server (e.g. as done for therabbitmq_peer_discovery_awsplugin here), we can integration test this plugin much simpler in the cluster-operator system tests.