Skip to content

Conversation

@coro
Copy link
Contributor

@coro coro commented Jun 11, 2021

This closes #647

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

This adds two columns to the output of kubectl get for RabbitmqClusters:

  • AllReplicasReady
  • ReconcileSuccess

These correspond to the equivalent fields in the Status of the object in question.

Additional Context

For example, when creating a 3-node cluster:
image

Once the deployment is complete:
image

After applying an update to the cluster:
image

After applying an update that fails to reconcile (in this case, some override config that was incorrect):
image

I considered adding system tests for this feature, however decided against it as I believe these tests would be too brittle to changes to kubectl itself, and feels outside the remit of testing for this repo.

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW! nice feature 🚢

@ChunyiLyu
Copy link
Contributor

I think @Zerpet would be very happy about this PR 😄 I remember him talking about adding print columns before.

@ablease
Copy link
Contributor

ablease commented Jun 14, 2021

This is great, thanks connor! :)

@coro coro merged commit 31c64b9 into main Jun 14, 2021
@coro coro deleted the merge-printing-columns branch June 14, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add printing columns to display relevant status information

5 participants