Skip to content

Conversation

@coro
Copy link
Contributor

@coro coro commented Jun 24, 2021

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Removes the undefined variable from the unit tests, and removes the RunAsGroup from the initContainer. Not sure how it made it through #724 without failing there.

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@coro coro merged commit a74ec73 into main Jun 24, 2021
@coro coro deleted the fix-unit-tests branch June 24, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants