Migrate to kubebuilder v3 #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use https://github.com/kubernetes-sigs/controller-runtime/tree/master/tools/setup-envtest since we want self-contained test dependencies for our integration tests. Migrate PROJECT file to kubebuilder v3 see https://kubebuilder.io/migration/manually_migration_guide_v2_v3.html Delete webhook files We don't use a webhook in the cluster-operator at the moment. Therefore delete the files. If we need a webhook in the future, we can easily re-create the files using 'kubebuilder create webhook' command. Rename flag metrics-addr to metrics-bind-address as described in https://kubebuilder.io/migration/manually_migration_guide_v2_v3.html#rename-the-manager-flags and kubernetes-sigs/kubebuilder#1839 Co-authored-by: Chunyi Lyu <clyu@pivotal.io>
since https://github.com/kubernetes-sigs/controller-runtime/blob/985e819db7af1cd17782ca7ad27644d0ca655054/tools/setup-envtest/env/env.go#L11 is only available in 1.16. Fixes failing GitHub actions.
coro
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #747
Pair: @ChunyiLyu