Add host and port to default-user secret. #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides additional information in the context of the Provisioned Service Binding spec https://k8s-service-bindings.github.io/spec/#provisioned-service When TLS is configured, we provide the AMQPS port, otherwise we provide the AMQP port. The host is the dns name of the service.
MirahImage
force-pushed
the
add-binding-host-port
branch
from
6e24138 to
11891b6
Compare
ChunyiLyu
suggested changes
Jul 7, 2021
Contributor
There was a problem hiding this comment.
Did some manual testing. Plugin ports are added successfully when the plugin is enabled at creation. However, when plugins are enabled after the cluster is already created, the service binding secret is not updated newly added plugin port.
What I did: 1) create a RMQ cluster with no additional plugins 2) update the cluster with one additional plugin like
spec:
...
rabbitmq:
additionalPlugins:
- rabbitmq_stomp- inspect the default user secret, which wasn't updated with the STOMP port after 5 minutes
apiVersion: v1
data:
default_user.conf:
host:
password:
port: NTY3Mg==
provider: cmFiYml0bXE=
type: cmFiYml0bXE=
username: Fix asciidoc.
MirahImage
force-pushed
the
add-binding-host-port
branch
from
f4f134a to
74495c2
Compare
ChunyiLyu
approved these changes
Jul 9, 2021
Contributor
ChunyiLyu
left a comment
ChunyiLyu
left a comment
There was a problem hiding this comment.
Update works now! Thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides additional information in the context of the Provisioned
Service Binding spec https://k8s-service-bindings.github.io/spec/#provisioned-service
When TLS is configured, we provide the AMQPS port, otherwise we provide
the AMQP port.
The host is the dns name of the service.
When additional plugins supporting other protocols are enabled, ports for those protocols are also added to the secret.