Skip to content

osiris_writer: Track diff between writer and replica offsets #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
the-mikedavis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

osiris_writer: Track diff between writer and replica offsets #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/osiris_writer.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,14 @@
-define(C_COMMITTED_OFFSET, ?C_NUM_LOG_FIELDS + 1).
-define(C_READERS, ?C_NUM_LOG_FIELDS + 2).
-define(C_EPOCH, ?C_NUM_LOG_FIELDS + 3).
-define(C_REPLICA_STALENESS, ?C_NUM_LOG_FIELDS + 4).
-define(ADD_COUNTER_FIELDS,
[
{committed_offset, ?C_COMMITTED_OFFSET, counter, "Last committed offset"},
{readers, ?C_READERS, counter, "Number of readers"},
{epoch, ?C_EPOCH, counter, "Current epoch"}
{epoch, ?C_EPOCH, counter, "Current epoch"},
{replica_staleness, ?C_REPLICA_STALENESS, gauge,
"Timestamp difference between last chunk written and oldest last chunk of any replica"}
]
).

Expand Down Expand Up @@ -288,7 +291,14 @@ handle_batch(Commands,

LastChId =
case osiris_log:tail_info(State2#?MODULE.log) of
{_, {_, TailChId, _TailTs}} ->
{_, {_, TailChId, TailTs}} ->
{Max, Min} = maps:fold(fun(_, {_, Ts}, {Max, Min}) ->
{max(Ts, Max),
min(Ts, Min)}
end,
{TailTs, TailTs},
State2#?MODULE.replica_state),
counters:put(Cnt, ?C_REPLICA_STALENESS, Max - Min),
TailChId;
_ ->
-1
Expand Down