Handle data loss in index and segment files #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunks that exist but are corrupted are not handled yet
This reverts commit b494782.
Instead of setting file descriptors to undefined we check the size _before_ each write and open a new segment if the current segment limits are reached. This allows us to better handle the case were the last segment was deleted due to missing data.
kjnilsson
changed the title
Contributor
|
I've found an issue where the index is 0 and there is segment data which it wasn't able to correctly truncate |
As this may affect the order in which the respective dirty pages will be flushed. Maybe.
kjnilsson
changed the title
kjnilsson
changed the title
Contributor
This appears fixed since 80600af |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a server was terminated without flushing data in the page cache this could cause errors during stream member recovery. This PR improves the recovery / truncation phase in multiple ways to handle situations where unflushed data is lost.
fsync index and segment when closing them(to be implemented separately)init, delete files that don't contain any useful data (empty, header-only, no valid chunks)osiris_log:overview, which can happen beforeinit, ignore files such as above (they get later deleted duringinit)Fixes #79