refactor consumer stream options #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the stream consumer options and the stream filter options. This implementation is similar to the golang implementation. So the idea is to have the same API ( as much as possible ) for all the amqp 1.0. clients. Add a new class StreamFilterOptions to configure only the filtering and leave the StreamConsumerOptions for offset and other future implementations Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Zerpet
reviewed
Sep 10, 2025
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
|
@Zerpet I renamed Following the Goland type Message struct {
Properties *MessageProperties
ApplicationProperties map[string]any
In the QPID message, you can set the message properties using the specific API(s), like: msg = Message(subject="subject", ttl=1)
msg.application_properties = {"app_property": "value"}
print(f"message subject: {msg.subject}, ttl: {msg.ttl}, app_property: {msg.application_properties['app_property']}") |
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
|
merged per conversation with @Zerpet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor consumer stream options and the stream filter options. This implementation is similar to the golang implementation. So the idea is to have the same API ( as much as possible ) for all the amqp 1.0. clients. Add a new class StreamFilterOptions to configure only the filtering and leave the StreamConsumerOptions for offset and other future implementations