Fix mnesia deletion return value in recent history exchange cleanup #10995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The caller expects this value to either be 'ok' or an error tuple but it
was returning `{atomic,ok}` causing a crash when deactivating this
plugin.
the-mikedavis
deleted the
md/recent-history-exchange-plugin/unwrap-deletion-return-value
branch
the-mikedavis
added a commit
that referenced
this pull request
Apr 14, 2024
Fix mnesia deletion return value in recent history exchange cleanup (backport #10995)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent history exchange currently returns
{atomic,ok}when deactivating the plugin, but the boot steps expect anok | {error, Reason}return spec.