Skip to content

Fix mnesia deletion return value in recent history exchange cleanup (backport #10995) #10996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2024
Merged

Fix mnesia deletion return value in recent history exchange cleanup (backport #10995) #10996

merged 2 commits into from
Apr 14, 2024
+18 −2

Conversation

@mergify
Copy link

@mergify mergify bot commented Apr 14, 2024

The recent history exchange currently returns {atomic,ok} when deactivating the plugin, but the boot steps expect an ok | {error, Reason} return spec.

This is an automatic backport of pull request #10995 done by Mergify.

@the-mikedavis @mergify
recent history exchange: Fix mnesia deletion return value
e0bdf70 
The caller expects this value to either be 'ok' or an error tuple but it
was returning `{atomic,ok}` causing a crash when deactivating this
plugin.

(cherry picked from commit 016697b)
@the-mikedavis @mergify
recent history exchange: Test plugin boot and cleanup steps
4115847 
(cherry picked from commit 21b5c90)
@the-mikedavis the-mikedavis added this to the 3.13.2 milestone Apr 14, 2024
@the-mikedavis the-mikedavis merged commit 597858b into v3.13.x Apr 14, 2024
@the-mikedavis the-mikedavis deleted the mergify/bp/v3.13.x/pr-10995 branch April 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@the-mikedavis the-mikedavis

Labels

None yet

Projects

None yet

Milestone

3.13.2

Development

Successfully merging this pull request may close these issues.

2 participants

@the-mikedavis