Skip to content

Conversation

@MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Apr 19, 2024

Proposed Changes

Fix issue with the command make docker-image. It was failing because it was not locating the generic-unix file.
The Makefile is uncompressing the generic-unix for no reason. It is not necessary as the dockerfile does not use it. Instead, it expects the uncompressed version. This PR should also remove that command which uncompresses the generic-unix file.

These changes are already addressed by this other PR #11042

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@mergify mergify bot added the make label Apr 19, 2024
@MarcialRosales MarcialRosales self-assigned this Apr 19, 2024
@MarcialRosales MarcialRosales requested a review from HoloRin April 19, 2024 12:22
the dockerfile is used by bazel and
make
@MarcialRosales MarcialRosales deleted the fix-issue-buiding-docker-images branch June 14, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants