-
Notifications
You must be signed in to change notification settings - Fork 4k
Use make for OCI workflow #11042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Use make for OCI workflow #11042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
Author
|
Images are tagged with the branch name and |
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Use make instead of bazel for the OCI workflow (cherry picked from commit 4e720d7) # Conflicts: # .github/workflows/oci-base.yaml # .github/workflows/oci.yaml # .github/workflows/rabbitmq_peer_discovery_aws.yaml
HoloRin
added a commit
that referenced
this pull request
Apr 19, 2024
* Use make for OCI workflow (#11042) * Use make instead of bazel for the OCI workflow (cherry picked from commit 4e720d7) # Conflicts: # .github/workflows/oci-base.yaml # .github/workflows/oci.yaml # .github/workflows/rabbitmq_peer_discovery_aws.yaml * fixup backport --------- Co-authored-by: Rin Kuryloski <rin.kuryloski@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a CI/Github Actions oriented PR. GHCR is used for caching,
rabbitmq/rabbitmq:buildcache-linux-$arch.Bazel builds should still work, such as:
bazel build //packaging/docker-image:rabbitmq-amd64bazel build //packaging/docker-image:rabbitmq-arm64bazel build //packaging/docker-image:rabbitmqAnd
make package-generic-unix docker-image TAR=tarworks on my mac as well.Additionally, this hybrid approach should work too:
bazel build :package-generic-unixmake -C packaging/docker-image GENERIC_UNIX_ARCHIVE=../../bazel-bin/package-generic-unix.tar.xz