Make rabbit_misc:which_applications/0 more resilient #11322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
In certain shutdown scenarios this function on Erlang 26 runs into exceptions that stem from application_controller. The objective of this function is to be an exception-safe version of application:which_applications/1, so let's handle more cases. This helps certain test suites avoid exceptions (process crash reports) logged during shutdown, which makes CT helpers fail test run even though there were no exceptions in RabbitMQ itself, and all the exception indicates is a certain edge case (during system shutdown) that application_controller does not care to handle.
michaelklishin
force-pushed
the
mk-which-applications-handle-more-exceptions
branch
from
5961c79 to
ca09440
Compare
michaelklishin
added a commit
that referenced
this pull request
May 25, 2024
Make rabbit_misc:which_applications/0 more resilient (backport #11322)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain shutdown scenarios this function on
Erlang 26 runs into exceptions that stem from
application_controller.
The objective of this function is to be
an exception-safe version of
application:which_applications/1, so let's
handle more cases.
This helps certain test suites avoid exceptions
(process crash reports) logged during shutdown,
which makes CT helpers fail test run even
though there were no exceptions in RabbitMQ
itself, and all the exception indicates is a
certain edge case (during system shutdown)
that application_controller does not care to handle.