Skip to content

Ensure rabbit_ff_controller doesn't block during boot #11392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Ensure rabbit_ff_controller doesn't block during boot #11392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions deps/rabbit/src/rabbit_ff_controller.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,20 @@ waiting_for_end_of_controller_task(

updating_feature_flag_states(
internal, Task, #?MODULE{from = From} = Data) ->
Reply = proceed_with_task(Task),

Reply = try
%% If this just exits with an error, the process
%% gets blocked on terminate while executing
%% wait_for_in_flight_operations. There is no
%% trace or log whatsoever of which has been the issue
proceed_with_task(Task)
catch
_:Reason:Stacktrace ->
?LOG_ERROR(
"Feature flags: task ~p failed with reason ~0p "
"and stacktrace ~0p", [Task, Reason, Stacktrace],
#{domain => ?RMQLOG_DOMAIN_FEAT_FLAGS}),
{error, Reason}
end,
?LOG_DEBUG(
"Feature flags: unregistering controller globally",
[],
Expand Down