Return non-0 exit code when failing to enable an experimental feature flag #12066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the prior behavior it can be unclear whether the text was a warning
and the feature flag was enabled anyways. We can use a non-zero exit
code and the `{:error, code, text}` return value to make it clear that
the flag wasn't enabled.
the-mikedavis
force-pushed
the
md/experimental-ff-ctl-fixes
branch
from
385efca to
dce8135
Compare
michaelklishin
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #11998. The main change is to return a non-zero exit code for
rabbitmqctl enable_feature_flag <expermental-flag>. When enablingkhepri_dblocally I wasn't 100% surerabbitmqctldidn't attempt to enable the flag regardless (i.e. the message seemed more like a warning) and I thought a non-zero exit code and the error text would make it more obvious.Also included are a typo fix and unit tests for the
--experimentalflag, one foralland another for a given experimental feature flag name.