amqp_client_SUITE: Fix frequent test failures #13409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
changed the title
dumbbell
changed the title
dumbbell
force-pushed
the
fix-test-flakes-in-amqp_client_SUITE
branch
6 times, most recently
from
f38acc2 to
804ac4e
Compare
ansd
requested changes
Feb 27, 2025
Member
|
I wonder whether instead of using |
dumbbell
force-pushed
the
fix-test-flakes-in-amqp_client_SUITE
branch
2 times, most recently
from
4188c23 to
b6cb91a
Compare
Collaborator
Author
We discussed this with David outside of GitHub and I agreed this is a good solution. |
dumbbell
force-pushed
the
fix-test-flakes-in-amqp_client_SUITE
branch
from
b6cb91a to
45c23e0
Compare
ansd
reviewed
Mar 4, 2025
dumbbell
force-pushed
the
fix-test-flakes-in-amqp_client_SUITE
branch
2 times, most recently
from
10d6b12 to
0c79228
Compare
[Why] This testsuite is very unstable and it is difficult to debug while it is part of a `parallel-ct` group. It also forced us to re-run the entire `parallel-ct` group just to retry that one testsuite.
[Why] Without this, the connection process crashes. We see this happenning in CI frequently.
Fix crash in close_sent since the client might receive the open frame if it previously sent the close frame in state open_sent. We explicitly ignore the open frame. The alternative is to add another gen_statem state CLOSE_PIPE which might be an overkill however. This commit also fixes a wrong comment: No sessions have begun if the app requests the connection to be closed in state open_sent.
The testcases are `leader_transfer_credit` and `dead_letter_into_stream`.
…t value [Why] If the testcase fails, it was leaving the low heartbeat value in place, leading to many subsequent tests to fail.
... instead of a global one. Otherwise, one connection failure, even if expected by a testcase, will affect all subsequent testcases negatively.
[Why] Many tests do not clean up their connections if they encounter a failure. This affects subsequent testcases negatively.
dumbbell
force-pushed
the
fix-test-flakes-in-amqp_client_SUITE
branch
from
0c79228 to
4d12efa
Compare
ansd
approved these changes
Mar 7, 2025
Collaborator
|
@Mergifyio backport v4.1.x v4.0.x |
✅ Backports have been created
|
This was referenced Mar 8, 2025
michaelklishin
added a commit
that referenced
this pull request
Mar 8, 2025
amqp_client_SUITE: Fix frequent test failures (backport #13409)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closemessage in theopen_sentstateidle_time_out_on_serverrestores heartbeat valueend_per_testcase/2