amqp_client_SUITE: Fix frequent test failures (backport #13409) #13474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] This testsuite is very unstable and it is difficult to debug while it is part of a `parallel-ct` group. It also forced us to re-run the entire `parallel-ct` group just to retry that one testsuite. (cherry picked from commit 2c66191)
[Why] Without this, the connection process crashes. We see this happenning in CI frequently. (cherry picked from commit 77e3636)
Fix crash in close_sent since the client might receive the open frame if it previously sent the close frame in state open_sent. We explicitly ignore the open frame. The alternative is to add another gen_statem state CLOSE_PIPE which might be an overkill however. This commit also fixes a wrong comment: No sessions have begun if the app requests the connection to be closed in state open_sent. (cherry picked from commit 6557686)
The testcases are `leader_transfer_credit` and `dead_letter_into_stream`. (cherry picked from commit 603ad0d)
…t value [Why] If the testcase fails, it was leaving the low heartbeat value in place, leading to many subsequent tests to fail. (cherry picked from commit 6084055)
... instead of a global one. Otherwise, one connection failure, even if expected by a testcase, will affect all subsequent testcases negatively. (cherry picked from commit ce5ba6d)
[Why] Many tests do not clean up their connections if they encounter a failure. This affects subsequent testcases negatively. (cherry picked from commit 4d12efa)
(cherry picked from commit 0f9b693)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closemessage in theopen_sentstateidle_time_out_on_serverrestores heartbeat valueend_per_testcase/2This is an automatic backport of pull request amqp_client_SUITE: Fix frequent test failures #13409 done by Mergify.