Update management UI workflows #13420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI can configure this variable to use a dynamic variable e.g. `${{
worker.temp }}`
Those branches were for Bazel builds. Bazel was replaced in main and 4.0+
The workflow to tests PRs is meant to run the short suite for management UI tests. On commits, we want to run the full suite to ensure that management UI tests are passing.
Contributor
MarcialRosales
left a comment
MarcialRosales
left a comment
There was a problem hiding this comment.
Looks good to me.
In certain environments, we may want to customise the docker image e.g. to use a proxy to avoid docker hub rate limiting. The default behaviour remains unchanged. The `if` logic was broken because `uname -a` returns the entire uname, including OS, Kernel version, machine type and what not. The string always starts with the OS i.e. Linux or Darwin, therefore, the matching for `arm*` was always false; therefore, it was always defaulting to the `else` image, which happens to be multi-arch. However, it was using `seleniarm`, which is a community driven effort, not the official Selenium account. In the official OSS image, version 123.0 is too old. The oldest available is 127.0. This commit bumps to the latest available. We could consider depending on version `4`. Version `4` refers to Selenium version, whilst version 123.0/133.0 refer to the browser version.
Zerpet
force-pushed
the
ci/update-selenium
branch
from
44ba23a to
ef8b4fc
Compare
Member
Author
|
I made a last minute change via ef8b4fc, when I realised that the logic to select the selenium image was not correct. As a result, I had to bump the image version. Were we targeting Chromium 123.0 for a particular reason? E.g. as a minimum supported version. I'm wondering whether using the latest available image version is ok. |
Contributor
|
I have tested your changes around the selenium/chromium docker image and it still works in both modes, silent and interactive. So you can go ahead. Thanks! @Zerpet |
[skip ci]
12 tasks
Zerpet
added a commit
that referenced
this pull request
Feb 25, 2025
Update management UI workflows (backport #13420)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR makes small tweaks to Management UI + Selenium workflows. The changes to the workflows
are mainly tidying up. There is an important change to run the full suite of Selenium tests
on
main. Prior to this PR, onmainwe run the "short" suite. This was not intended. Theshort suite is meant for PRs.
Types of Changes
Checklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.