Skip to content

Conversation

@Zerpet
Copy link
Member

@Zerpet Zerpet commented Feb 25, 2025

Proposed Changes

Prior to this commit, if a test failed, the script 'run-suites.sh' would
exit with non-zero status, stopping the exection of the job; therefore,
the steps to move the logs to the expected location won't be executed.
This commit separates the tests from the log preparation.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Prior to this commit, if a test failed, the script 'run-suites.sh' would
exit with non-zero status, stopping the exection of the job; therefore,
the steps to move the logs to the expected location won't be executed.
This commit separates the tests from the log preparation.
@Zerpet Zerpet self-assigned this Feb 25, 2025
@Zerpet
Copy link
Member Author

Zerpet commented Feb 25, 2025

Noticed this issue during this workflow run: https://github.com/rabbitmq/rabbitmq-server/actions/runs/13526134417/job/37797037204

@michaelklishin
Copy link
Collaborator

@MarcialRosales should we merge this one?

Copy link
Contributor

@MarcialRosales MarcialRosales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.
@michaelklishin yes it can be merged. Thanks!

@Zerpet Zerpet merged commit ad0c209 into main Mar 12, 2025
4 of 267 checks passed
@Zerpet Zerpet deleted the fix-selenium-log-collection branch March 12, 2025 10:00
michaelklishin added a commit that referenced this pull request Mar 12, 2025
Fix log collection in Selenium workflows (backport #13425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants