Improve oauth2 idp-initiated login #13476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcialRosales
force-pushed
the
mgt-oauth-login-without-redirect
branch
from
cdc8f22 to
8847fe6
Compare
MarcialRosales
force-pushed
the
mgt-oauth-login-without-redirect
branch
from
4951e39 to
e24ffbb
Compare
MarcialRosales
force-pushed
the
mgt-oauth-login-without-redirect
branch
from
11dcbcd to
69b5486
Compare
6 tasks
michaelklishin
added a commit
that referenced
this pull request
Mar 12, 2025
Improve oauth2 idp-initiated login (backport #13476)
6 tasks
michaelklishin
added a commit
that referenced
this pull request
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is an improvement to the
/loginendpoint (rabbit_mgmt_login) used for idp-initiated logons in the management ui.The previous implementation produced a warning message in the browser the first time the form was submitted. The warning message warned the user that the form was about to be submitted again. This was because the response page to the POST request contained a javascript code that refreshed the page.
With this new change, the
rabbit_mgmt_loginmodule instead replies with a redirect 302 including a cookie with the token. This cookie is very short-lived, when the user is redirected to the Overview page of the management, the cookie is already gone.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply