Selenium: minor refactoring #13963
Merged
Selenium: minor refactoring #13963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcialRosales
force-pushed
the
selenium-use-var-over-tmp
branch
from
24647b2 to
95a2e37
Compare
Zerpet
reviewed
May 28, 2025
Comment on lines
+77
to
81
| env: | ||
| SELENIUM_ARTIFACTS: ${{ steps.run-suites.outputs.SELENIUM_ARTIFACTS }} | ||
| with: | ||
| name: test-artifacts-${{ matrix.browser }}-${{ matrix.erlang_version }} | ||
| path: | |
Member
There was a problem hiding this comment.
You probably want to use the env var in the path to upload artefacts, right?
Contributor
Author
There was a problem hiding this comment.
absolutely. I just pushed a missing commit
Member
MarcialRosales
force-pushed
the
selenium-use-var-over-tmp
branch
from
c207e85 to
94cba43
Compare
Contributor
Author
|
Absolutely ! I normally squash before submitting for review. |
6 tasks
michaelklishin
added a commit
that referenced
this pull request
May 29, 2025
Selenium: minor refactoring (backport #13963)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use /var over /tmp to store conf files for each suite. Without this change, it is not possible to run selenium unless docker or docker desktop is used.
Rename doWhile to doUntil as it is more appropriate name.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply