Remove AMQP backpressure test expectation #14007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case
tcp_back_pressure_rabbitmq_internal_flow_quorum_queuesucceedsconsistently locally on macOS and fails consistently in CI since 30 May
2025.
CI also shows a test failure instance of
tcp_back_pressure_rabbitmq_internal_flow_classic_queue, albeit much rearer.This test case succeeds in CI when using ubuntu-22.04 but fails with ubuntu-24.04.
Even before 30 May 2025, ubuntu-24.04 was used. However the GitHub runner
version was updated from Version: 20250511.1.0 to Version: 20250527.1.0
which presumably started to cause this test to fail.
This hypothesis cannot be validated because the GitHub actions
definitions YAML file doesn't provide a means to configure this version.
File
images/ubuntu/Ubuntu2404-Readme.mdin actions/runner-images@ubuntu24/20250511.1...ubuntu24/20250527.1 shows the diff.The most notable changes are probably the kernel version change from Kernel Version: 6.11.0-1013-azure to Kernel Version: 6.11.0-1015-azure and some changes to file
images/ubuntu/scripts/build/configure-environment.shThere seem to be no RabbitMQ related changes causing this test to fail
because this test also fails with an older RabbitMQ version with the new runner
Version: 20250527.1.0.
Neither
mecknorinet:setopts(Socket, [{active, once}])cause thetest failure because the test also fails with the former
erlang:suspend_process/1anderlang:resume_process/1.The test fails due to the following timeout in the writer proc on the
server:
Even after the CT test case resumes consumption,
the server still times out writing to the socket. The Wireshark capture validates that there is no logic error on the server: The TCP window of the receiving client is full for 30 seconds, the client doesn't receive fast enough, hence the server times out writing to the socket and closes the connection.
The most important test expectation that is kept in place is that the
server won't send all the messages if the client can't receive fast
enough.