Skip to content

Shovel bufixes #14732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelklishin merged 7 commits into from
Oct 17, 2025
Merged

Shovel bufixes #14732

michaelklishin merged 7 commits into from
Oct 17, 2025

Conversation

@dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho commented Oct 15, 2025

This PR adds a few testcases common to all protocols and some bugfixes:

  • Count confirmed messages just once in local shovels
  • Auto-delete amqp10 shovels with 0 messages set to transfer
  • Reject amqp10 shovels with delete-after and no-ack options set together - same behaviour as 0.9.1 and local shovels

@dcorbacho dcorbacho added this to the 4.2.0 milestone Oct 15, 2025
@michaelklishin michaelklishin merged commit 0ee1c66 into main Oct 17, 2025
288 of 289 checks passed
@michaelklishin michaelklishin deleted the shovel-tests branch October 17, 2025 23:12
@mergify mergify bot mentioned this pull request Oct 17, 2025
Merged
@michaelklishin michaelklishin restored the shovel-tests branch October 19, 2025 19:11
@michaelklishin michaelklishin deleted the shovel-tests branch October 19, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

No one assigned

Labels

backport-v4.2.x bug

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dcorbacho @michaelklishin