Reorder queue creation form to make vhost dropdown reset less likely (backport #15016) #15017
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a queue in the management UI, selecting a non-`/` virtual host, then a queue type different than the default for that virtual host causes the vhost selection to reset to `/`. This happens because changing the queue type calls `update()`, which re-renders the entire form to display specific data for that virtual host, losing the user's virtual host selection. This change reorders the "Add a new queue" form fields so that "Type" appears before "Virtual host". Users now select the queue type first, triggering the form re-render before they make their vhost selection. This prevents the vhost reset without requiring JS wizardry/hacks to preserve form state across re-renders. (cherry picked from commit 50b5aae)
michaelklishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15015
When creating a queue in the management UI, selecting a non-
/virtual host, then a queue type different than the default for that virtual host causes the vhost selection to reset to/. This happens because changing the queue type callsupdate(), which re-renders the entire form to display specific data for that virtual host, losing the user's virtual host selection.This change reorders the "Add a new queue" form fields so that "Type" appears before "Virtual host". Users now select the queue type first, triggering the form re-render before they make their vhost selection. This prevents the vhost reset without requiring JS wizardry/hacks to preserve form state across re-renders.
This is an automatic backport of pull request #15016 done by Mergify.