Restore -detached argument detection in rabbitmq-server
#15036
Merged
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
lukebakken/rabbitmq-server-detached
branch
2 times, most recently
from
1f51f36 to
304ebf1
Compare
Commit 68c3055 removed the code that detected the `-detached` command-line argument and set the `detached` variable. However, the conditional check for `$detached` remained, along with a comment referencing "the code above" that no longer exists. This left orphaned code that could never execute its intended branch. This change restores the argument detection loop that sets `detached` to `"true"` when `-detached` is found in the command-line arguments. The loop uses POSIX-compliant syntax to iterate through all positional parameters and check for the `-detached` flag. Additionally, this change replaces the deprecated `-o` operator with `||` in the conditional test, following POSIX best practices for boolean OR operations in shell scripts.
lukebakken
force-pushed
the
lukebakken/rabbitmq-server-detached
branch
from
304ebf1 to
a48ea81
Compare
michaelklishin
approved these changes
Nov 29, 2025
Collaborator
|
The context here is docker-library/rabbitmq#778 and rabbitmq/cluster-operator#2012. |
michaelklishin
added a commit
that referenced
this pull request
Nov 29, 2025
Restore `-detached` argument detection in `rabbitmq-server` (backport #15036)
Collaborator
Author
|
Thanks @michaelklishin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 68c3055 removed the code that detected the
-detachedcommand-line argument and set thedetachedvariable. However, the conditional check for$detachedremained, along with a comment referencing "the code above" that no longer exists. This left orphaned code that could never execute its intended branch.This change restores the argument detection loop that sets
detachedto"true"when-detachedis found in the command-line arguments. The loop uses POSIX-compliant syntax to iterate through all positional parameters and check for the-detachedflag.Additionally, this change replaces the deprecated
-ooperator with||in the conditional test, following POSIX best practices for boolean OR operations in shell scripts.