Pass all members to synchronous Ra operations #2046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this will make these more work reliably when leadership is in flux. Also ensure that servers started and added after the initial declare uses the same configuration.
Contributor
|
Looks good, ship it. How to we stress-test this in LREs? Would this help? https://github.com/rabbitmq/rabbitmq-server-boshrelease/tree/master/jobs/periodic_shutdown |
Contributor
Author
|
I think it's tricky to test this specific thing but lots of queue declare during leader elections would be the way I'd approach it. |
Contributor
|
If nodes get periodically shut-down and consumers get forcefully disconnect, when consumers reconnect they should first try to declare queues before consuming from them. Would that work? |
dcorbacho
approved these changes
Jul 2, 2019
Collaborator
|
@kjnilsson @dcorbacho FYI, this has a legitimate conflict with #2053. |
michaelklishin
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this will make these more work reliably when leadership is in flux.
Also ensure that servers started and added after the initial declare
uses the same configuration.
requires rabbitmq/ra#100.