Skip to content

Use powershell as a backup to handle.exe #6614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 11, 2022
Merged

Use powershell as a backup to handle.exe #6614

merged 4 commits into from
Dec 11, 2022

Conversation

@lukebakken
Copy link
Collaborator

Fixes #6613

@lukebakken lukebakken self-assigned this Dec 9, 2022
@lukebakken
Copy link
Collaborator Author

@michaelklishin turns out that Erlang uses cmd.exe when os:cmd is called to then run powershell.exe. Not all that efficient. I have code to execute powershell.exe directly via open_port ... should I do that in this PR as well?

@lukebakken
Copy link
Collaborator Author

@michaelklishin check this commit out, which runs Powershell directly -

a40c682

I did a lot of independent testing using this code and I'll be testing this branch on Windows a bit more before marking the PR as ready.

@lukebakken lukebakken force-pushed the lukebakken/rabbitmq-server-6613 branch from a40c682 to f7b65ab Compare December 10, 2022 21:19
@lukebakken lukebakken marked this pull request as ready for review December 10, 2022 22:06
@lukebakken lukebakken marked this pull request as draft December 10, 2022 22:08
@lukebakken lukebakken marked this pull request as ready for review December 10, 2022 22:36
@lukebakken
Copy link
Collaborator Author

@michaelklishin all set.

@michaelklishin
Copy link
Collaborator

For some reason I could not build a Windows installer in a Linux VM but this looks good. I will merge and try the Concourse package before backporting.

@michaelklishin michaelklishin added this to the 3.11.5 milestone Dec 11, 2022
@michaelklishin michaelklishin merged commit 6a89f86 into main Dec 11, 2022
@michaelklishin michaelklishin deleted the lukebakken/rabbitmq-server-6613 branch December 11, 2022 14:48
@mergify mergify bot mentioned this pull request Dec 11, 2022
Merged
michaelklishin added a commit that referenced this pull request Dec 11, 2022
@michaelklishin
Merge pull request #6626 from rabbitmq/mergify/bp/v3.11.x/pr-6614
76a3f43 
Use powershell as a backup to handle.exe (backport #6614)
@lukebakken
Copy link
Collaborator Author

@michaelklishin thanks! That's odd you couldn't build ... what was the error?

@michaelklishin
Copy link
Collaborator

When I try to gmake package-windows the first time, it builds successfully but the second time I get a "filename mismatch" from a packaging target that does unzip -q.

I ended up testing this with this alpha build. Works like a charm on a Windows host without handle.exe.

michaelklishin added a commit that referenced this pull request Dec 11, 2022
@michaelklishin
Merge pull request #6627 from rabbitmq/mergify/bp/v3.10.x/pr-6626
c646303 
Use powershell as a backup to handle.exe (backport #6614) (backport #6626)
@lukebakken
Copy link
Collaborator Author

Ah, I think I've seen that. I always remove everything from the PACKAGES output directory before each run.

@michaelklishin michaelklishin removed this from the 3.11.5 milestone Dec 12, 2022
@michaelklishin michaelklishin mentioned this pull request Dec 12, 2022
Merged
@lukebakken lukebakken mentioned this pull request Jun 29, 2023
Closed
lukebakken added a commit that referenced this pull request Jul 26, 2023
@lukebakken
Remove Powershell as a backup to handle.exe
9f6bb7a 
If a user does not have `handle.exe` installed in the `PATH` of their
Windows system, a message will be logged once, and then the total
handles being used will be set to `0`.

Fixes #8700

Follow-up to:
* #6614
* #6613
* #8541
@lukebakken lukebakken mentioned this pull request Jul 26, 2023
Merged
lukebakken added a commit that referenced this pull request Jul 31, 2023
@lukebakken
Remove Powershell as a backup to handle.exe
90ca18f 
If a user does not have `handle.exe` installed in the `PATH` of their
Windows system, a message will be logged once, and then the total
handles being used will be set to `0`.

Fixes #8700

Follow-up to:
* #6614
* #6613
* #8541
lukebakken added a commit that referenced this pull request Aug 1, 2023
@lukebakken
Remove Powershell as a backup to handle.exe
3067307 
If a user does not have `handle.exe` installed in the `PATH` of their
Windows system, a message will be logged once, and then the total
handles being used will be set to `0`.

Fixes #8700

Follow-up to:
* #6614
* #6613
* #8541
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
@lukebakken @mergify
Remove Powershell as a backup to handle.exe
d0e9bcc 
If a user does not have `handle.exe` installed in the `PATH` of their
Windows system, a message will be logged once, and then the total
handles being used will be set to `0`.

Fixes #8700

Follow-up to:
* #6614
* #6613
* #8541

(cherry picked from commit 3067307)
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
@lukebakken @mergify
Remove Powershell as a backup to handle.exe
2405191 
If a user does not have `handle.exe` installed in the `PATH` of their
Windows system, a message will be logged once, and then the total
handles being used will be set to `0`.

Fixes #8700

Follow-up to:
* #6614
* #6613
* #8541

(cherry picked from commit 3067307)
(cherry picked from commit d0e9bcc)
mergify bot pushed a commit that referenced this pull request Aug 2, 2023
@lukebakken @mergify
Remove Powershell as a backup to handle.exe
0896918 
If a user does not have `handle.exe` installed in the `PATH` of their
Windows system, a message will be logged once, and then the total
handles being used will be set to `0`.

Fixes #8700

Follow-up to:
* #6614
* #6613
* #8541

(cherry picked from commit 3067307)
(cherry picked from commit d0e9bcc)
(cherry picked from commit 2405191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

@lukebakken lukebakken

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use powershell if handle.exe is missing or reports an error

2 participants

@lukebakken @michaelklishin