Do not force mix format check as part of build #8872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes joint 1.14/1.15 elixir compatibility too impractical the format check is still performed in ci by bazel
michaelklishin
approved these changes
Jul 17, 2023
michaelklishin
added a commit
that referenced
this pull request
Jul 17, 2023
Do not force mix format check as part of build (backport #8872)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes joint 1.14/1.15 elixir compatibility too impractical
the format check is still performed in ci by bazel
cd deps/rabbitmq_cli && mix formatwill still work just fine (but should only be performed with the latest elixir, sincemix formatdoes not produce compatible results across elixir minors)