Skip to content

Conversation

@pilwon
Copy link
Contributor

@pilwon pilwon commented Aug 19, 2014

  • Added missing Tutorial 6 code.
  • Improved overall code consistency and organization.
  • Fixed bugs (ex: not setting exclusive tag when the tutorial article mentions it, error in arg parsing)
  • Cleaned up minor things. (ex: receiver/worker/server keeps running and consuming messages)

@pilwon pilwon changed the title Added Tutorial 6 to Go language + Improved, fixed bug, cleaned up code Added Tutorial 6 & Improved, fixed bug, cleaned up code for Go language Aug 19, 2014
@michaelklishin
Copy link
Contributor

I don't want to be a pain in the neck but in the future, please do not submit a pull request that adds something AND also modifies formatting/"cleans up" a lot of other files. This is just not polite to the maintainer.

michaelklishin added a commit that referenced this pull request Aug 19, 2014
Added Tutorial 6 & Improved, fixed bug, cleaned up code for Go language
@michaelklishin michaelklishin merged commit 30228db into rabbitmq:master Aug 19, 2014
@pilwon pilwon deleted the go_improvements branch August 23, 2014 22:16
@pilwon
Copy link
Contributor Author

pilwon commented Aug 23, 2014

@michaelklishin Gotcha. Was my PR helpful at all?

@michaelklishin
Copy link
Contributor

@pilwon well, I merged it ;)

@pilwon
Copy link
Contributor Author

pilwon commented Aug 24, 2014

@michaelklishin 👍

@dumbbell dumbbell modified the milestone: n/a Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants