Skip to content

Conversation

@HoloRin
Copy link
Collaborator

@HoloRin HoloRin commented Mar 3, 2023

This is quite a simple macro, but had the unfortunate side effect of introducing a dependency on rules_pkg. By dropping the macro, we can drop the dependency.

For reference, the macro was as follows:

def source_archive():
    source_tree(
        name = "source_tree",
        deps = [":erlang_app"],
    )

    pkg_tar(
        name = "source_archive",
        srcs = [":source_tree"],
        package_dir = "deps",
        strip_prefix = "source_tree",
        visibility = ["//visibility:public"],
    )

@HoloRin HoloRin added this to the 3.10.0 milestone Mar 3, 2023
@HoloRin HoloRin force-pushed the drop-source-archive-rule branch 2 times, most recently from b1f9f63 to a4f39ab Compare March 10, 2023 09:23
@HoloRin HoloRin force-pushed the drop-source-archive-rule branch from a4f39ab to 2ce9175 Compare March 18, 2023 16:05
HoloRin added 2 commits May 4, 2023 09:45
This is quite a simple macro, but had the unfortunate side effect of
introducing a dependency on rules_pkg. By dropping the macro, we can
drop the dependency.

For reference, the macro was as follows:

```starlark
def source_archive():
    source_tree(
        name = "source_tree",
        deps = [":erlang_app"],
    )

    pkg_tar(
        name = "source_archive",
        srcs = [":source_tree"],
        package_dir = "deps",
        strip_prefix = "source_tree",
        visibility = ["//visibility:public"],
    )
```
@HoloRin HoloRin force-pushed the drop-source-archive-rule branch from 2ce9175 to 6bc5fbe Compare May 4, 2023 07:45
@HoloRin HoloRin enabled auto-merge May 4, 2023 07:45
@HoloRin HoloRin merged commit 1f2538b into main May 4, 2023
@HoloRin HoloRin deleted the drop-source-archive-rule branch May 4, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants