Skip to content

Drop the source_archive macro #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HoloRin merged 2 commits into from
May 4, 2023
Merged

Drop the source_archive macro #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4b718c
Drop the source_archive rule
HoloRin Mar 3, 2023
6bc5fbe
Use source_tree instead of source_archive in test suite
HoloRin Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ bazel_dep(
repo_name = "io_bazel_rules_go",
version = "0.37.0",
)
bazel_dep(
name = "rules_pkg",
version = "0.5.1",
)
bazel_dep(
name = "bazel_skylib",
version = "1.3.0",
Expand Down
10 changes: 0 additions & 10 deletions internal_deps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,6 @@ load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
load(":hex_archive.bzl", "hex_archive")

def rules_erlang_internal_deps():
maybe(
http_archive,
name = "rules_pkg",
sha256 = "a89e203d3cf264e564fcb96b6e06dd70bc0557356eb48400ce4b5d97c2c3720d",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.5.1/rules_pkg-0.5.1.tar.gz",
"https://github.com/bazelbuild/rules_pkg/releases/download/0.5.1/rules_pkg-0.5.1.tar.gz",
],
)

maybe(
http_archive,
name = "bazel_skylib",
Expand Down
3 changes: 0 additions & 3 deletions internal_setup.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
load("//gazelle:deps.bzl", "gazelle_deps")
load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")

def rules_erlang_internal_setup(
go_repository_default_config = "//:WORKSPACE.bazel"):
Expand All @@ -17,5 +16,3 @@ def rules_erlang_internal_setup(

# gazelle:repository_macro gazelle/deps.bzl%gazelle_deps
gazelle_deps()

rules_pkg_dependencies()
19 changes: 0 additions & 19 deletions source_archive.bzl
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions test/shard_suite/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ load(
"ct_suite",
)
load(
"@rules_erlang//:source_archive.bzl",
"source_archive",
"@rules_erlang//:source_tree.bzl",
"source_tree",
)

APP_NAME = "shard_suite"
Expand Down Expand Up @@ -99,4 +99,7 @@ ct_suite(
],
)

source_archive()
source_tree(
name = "source_tree",
deps = [":erlang_app"],
)