chore(rules): Redesign rule actions#221
Merged
rabbitstack merged 8 commits intomasterfrom Dec 19, 2023
Merged
Conversation
The rule action block defined as a Go template is very unintuitive and hard to grok for users not familiar with the language. Generating an alert should be a default behaviour for all rules. This is why we shift from explicit to implicit alert generation. The action block is now an array of predefined response actions, such as `kill`. When the alert is generated, the rule name is used as its title. For building a more informative alert, the text can be built via the new `output` element, which accepts filter fields expressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule action block defined as a Go template is very unintuitive and hard to grok for users not familiar with the language. Generating an alert should be a default behavior for all rules. This is why we shift from explicit to implicit alert generation. The action block is now an array of predefined response actions, such as
kill. When the alert is generated, the rule name is used as its title. For building a more informative alert, the text can be built via the newoutputelement, which accepts filter field expressions.