Remove storageclassname from helm config #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudnull
approved these changes
Apr 9, 2025
sulochan
force-pushed
the
removestorageclassnames
branch
2 times, most recently
from
39abe59 to
c02ed25
Compare
If not strorageClassName is sepcified the default storage class is used. There might be environments where the `general` class name is not used. In genestack we are now defaulting to longhorn-general as the default. Where we need specific class it should be an override, where we dont leave it to use the default.
sulochan
force-pushed
the
removestorageclassnames
branch
from
c02ed25 to
bdc59b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not strorageClassName is sepcified the default storage class is used. There might be environments where the
generalclass name is not used. In genestack we are now defaulting to longhorn-general as the default. Where we need specific class it should be an override, where we dont leave it to use the default.