Skip to content

Conversation

@odeckmyn
Copy link
Contributor

Based on rriifftt implementation I've added another wait and fixed the bug for my usage.

This PR solves everything for me.

@rriifftt
Copy link
Contributor

@odeckmyn I see it need waiter for publish_version() after update_function_configuration() process too.

it seems like add waiter method in this class is better..?
but the way, looks good to me.

@odeckmyn
Copy link
Contributor Author

@odeckmyn I see it need waiter for publish_version() after update_function_configuration() process too.

it seems like add waiter method in this class is better..? but the way, looks good to me.

To be honest I don't know :-) Feel free to make any modification. In my case, these patches solved my issue. And your work made my day :-)

@rriifftt
Copy link
Contributor

@odeckmyn sounds good.
Well, I don't have the authority to merge...

@jarosser06
Copy link
Contributor

I don't maintain this anymore, partially b/c I'm no longer at Rackspace, and partially b/c I no longer use the tool itself for anything other than a library for my own workflow.

I'll ping a buddy of mine still at Rackspace to take a look at this PR.

@gdelvalle
Copy link
Contributor

I'll try to get this handled for you guys. Give me a few days to free up so I can properly review thee project, this problem and the proposed solution. At a glance it seems reasonable.

@rriifftt
Copy link
Contributor

@gdelvalle Is it likely that this case cannot be merged?

Copy link
Contributor

@gdelvalle gdelvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@gdelvalle gdelvalle merged commit 1e4c42b into rackerlabs:master Apr 15, 2022
@rriifftt
Copy link
Contributor

Thanks for Reviewing

@gdelvalle
Copy link
Contributor

Release: https://github.com/rackerlabs/lambda-uploader/releases/tag/v1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants