fix(ironic): add snponly.efi to the tftp server #1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the legacy tftp booting to work with Ironic we need to serve up the snponly.efi. Rather than share the mount from Ironic so that the file is copied in by Ironic just load it the same way that OpenStack Helm loads it into the container.
This PVC is unused for any data so let's retire it to not leave used cruft behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to ttftp boot over UEFI we need to serve up the snponly.efi file so include that in the build of the container. Remove the unused understack-data PVC because this sent us down the wrong path at first and its unnecessary cruft.