fix(ironic): update resource_class matching to make model more generic #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code looked for a pattern in the model name which didn't necessarily always exist. So make it more generic by using the leading part instead of a specific regex match. Make the manufacturer strip the whitespace the same way.
cardoe
force-pushed
the
fix-inspect-model-name
branch
from
f521a3f to
3a3c756
Compare
nicholaskuechler
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code looked for a pattern in the model name which didn't necessarily always exist. So make it more generic by using the leading part instead of a specific regex match. Make the manufacturer strip the whitespace the same way.